BlockSettingsDropdown: No need to cast 'clientIds' to an array #59940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Code Quality
Mamaduka
commented
Mar 18, 2024
Comment on lines
-101
to
-104
| const clientId = Array.isArray( clientIds ) | ||
| ? clientIds[ 0 ] | ||
| : clientId; | ||
| insertBeforeBlock( clientId ); |
There was a problem hiding this comment.
Great catch, thanks I confirm this had to be clientIds in the first place!
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 1.71 MB ℹ️ View Unchanged
|
tyxla
approved these changes
Mar 18, 2024
Comment on lines
-101
to
-104
| const clientId = Array.isArray( clientIds ) | ||
| ? clientIds[ 0 ] | ||
| : clientId; | ||
| insertBeforeBlock( clientId ); |
There was a problem hiding this comment.
Great catch, thanks I confirm this had to be clientIds in the first place!
| }, | ||
| onInsertAfter() { | ||
| const clientId = Array.isArray( clientIds ) |
There was a problem hiding this comment.
Confirming that the rest of the code already expects arrays and doesn't do additional checks. Good find!
|
Thanks for the review, @tyxla! |
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Mar 27, 2024
…ress#59940) * BlockSettingsDropdown: No need to cast 'clientIds' to an array * Fix clientId logic for 'onInsertBefore' and 'onInsertAfter' actions Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR removes unnecessary casting to an array of
clientIdsfor theBlockSettingsDropdownand fixes leftover logic inBlockActionscomponent.Why?
The parent
BlockSettingsMenucomponent always receivesclientIdsas an array.getSelectedBlockClientIdsselector, which always returns an array.Testing Instructions
Testing Instructions for Keyboard
Same.
Screenshots or screencast